redis / redis/node-redis

Redis issue on module-redis-fork

Open
#1,605 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
17.6k
Forks
2k
Avg merge
2d 3h
Merged PRs (30d)
40

Description

Issue

Hi everyone,

I have an issue while trying to interact with Redis in those conditions:

  1. Redis instance with Redisearch module,
  2. Create node-redis client before Redis module fork is ongoing,
  3. Redis module fork is on-going

The behaviour that I get is that "send_command" stays idle until the fork stops.
When the fork ends I get this error:
debug mode (node-redis) ->
Redis connection is gone from end event
client err ->
AbortError: Redis connection lost and command aborted. It might have been processed.

After I get this error the commands from the same client (without creating a new client) come back to works fine.

On every fork, I got the same behaviour.


Environment
  • Node.js Version: v14.15.1
  • Redis Version: 6.0.4
  • redisearch Version: 1.6.15
  • node-redis Version: 3.2
  • Platform: Server 128GB RAM, 8 Core, Debian

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior with node-redis 3.2, Redis 6.0.4, and RediSearch 1.6.15 by creating the client before the module fork. Start by tracing command sending and connection error handling during the fork. Done means commands are not left idle or aborted when the fork ends, and the existing client continues working.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, redis
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.