"total_retry_time" not include connection timeout
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 17.6k
- Forks
- 2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 40
Description
- Version: 2.8.0
- Platform: node v8.11.2 on ubuntu
- Description: Connection to an IP which can't be reached, emit a retry event after a very very long time during every retrying... What I meas the
total_retry_timenot include connecting time, and retry event will be emited after another connection timeout, if theconnection timeoutnot setted, default is quite a long time.
// connect to an IP not exists
redis.createClient(6379, '999.999.999.999', options);
I solved this with a connect_timeout param which is abandoned by official...this will solve the first time connecting timeout problems...(max connection timeout set to 2S before emiting retry event )
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue using redis.createClient with an unreachable IP and the options object described in the report. Trace how connection timeout, retry events, and total_retry_time are measured. Done means the connecting time is included and retry events occur within the configured connection timeout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, redis, typescript
- Domain
- backend, networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100