redis / redis/node-redis

`command_obj` not defined.

Open
#1,274 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Pending Author Input
Dominant language
TypeScript
Stars
17.6k
Forks
2k
Avg merge
2d 3h
Merged PRs (30d)
40

Description

I wonder why this happens but I am having concurrent reads at scale. "version": "2.8.0"

/root/project-x/node_modules/redis/index.js:687
    if (command_obj.error) {
                   ^

TypeError: Cannot read property 'error' of undefined
    at RedisClient.return_error (/root/project-x/node_modules/redis/index.js:687:20)
    at JavascriptRedisParser.returnError (/root/project-x/node_modules/redis/index.js:196:18)
    at JavascriptRedisParser.execute (/root/project-x/node_modules/redis-parser/lib/parser.js:572:12)
    at Socket.<anonymous> (/root/project-x/node_modules/redis/index.js:274:27)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at addChunk (_stream_readable.js:266:12)
    at readableAddChunk (_stream_readable.js:253:11)
    at Socket.Readable.push (_stream_readable.js:211:10)
    at TCP.onread (net.js:585:20)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with node_modules/redis/index.js at RedisClient.return_error and follow the parser path through redis-parser/lib/parser.js. Reproduce the reported failure under concurrent reads using Redis client version 2.8.0. Done would require identifying why command_obj is undefined and adding a verified fix or regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, redis
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.