redhat-et / redhat-et/skillimage
Follow-up: minor improvements from PR #4 review
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 9
- Forks
- 3
- Avg merge
- 18m
- Merged PRs (30d)
- 1
Description
Minor items deferred from PR #4 code review:
From Kimi-2.5 review:
- Validate tag destination reference format —
skillctl tagdoesn't validate the destination ref format early; invalid refs fail later with a confusing store error. Add format validation inpkg/oci/tag.go. - Add tests for credential store —
credentialStore()andpodmanAuthPath()inpkg/oci/push.gohave no unit tests. Add tests covering: Docker-only, Podman-only, both present, neither present.
From CodeRabbit review:
- REGISTRY_AUTH_FILE support — Honor
REGISTRY_AUTH_FILEenv var and try all Podman auth paths ($XDG_RUNTIME_DIR/containers/auth.jsonand$HOME/.config/containers/auth.json) instead of stopping at the first one found.
All are low-severity robustness improvements — no correctness impact.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/oci/tag.go and pkg/oci/push.go, then inspect the existing pkg/oci tests and credential lookup entry points. Done means invalid tag destination references fail early, credentialStore() and podmanAuthPath() cover the four listed cases, and REGISTRY_AUTH_FILE plus both Podman auth paths are honored; run the package tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100