redhat-et / redhat-et/skillimage
test: expand BuildCollectionArtifact test coverage
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 9
- Forks
- 3
- Avg merge
- 18m
- Merged PRs (30d)
- 1
Description
From code review of PR #15.
TestBuildCollectionArtifact only asserts that the digest is non-empty. It should also verify:
- Manifest has correct
ArtifactType - Annotations are populated (title, version, collection name)
- Layer media type is
application/vnd.skillimage.collection.v1+yaml - Round-trip via
extractCollectionYAMLreturns the original collection
File: pkg/oci/collection_test.go
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open pkg/oci/collection_test.go and locate TestBuildCollectionArtifact. Add checks for the manifest ArtifactType, title/version/collection-name annotations, the specified layer media type, and the extractCollectionYAML round trip. Run the focused test and confirm all listed values and the original collection are preserved.
Written by the indexing model from the issue text.
Assessment
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100