redhat-et / redhat-et/ProtoBot

Land the already-produced fix for AGENTS.md's stale 'documents listed above' phrase, stranded on an orphaned branch

Open Beginner friendly
#144 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

documentation ready-for-triage triaged
Dominant language
Go
Stars
5
Forks
6
Avg merge
23h 24m
Merged PRs (30d)
66

Description

What happened

Review round 2 on PR #143 flagged that AGENTS.md's 'Aligning skills with the specification hierarchy' section still says a skill 'must remain consistent with the documents listed above' -- leftover list-based language contradicting the path-prefix membership rule this same PR introduced elsewhere in the file. JohnStrunk merged the PR 4 minutes later without addressing it. A fix-agent run (35363926874), dispatched off the CHANGES_REQUESTED review, was still executing when the merge happened at 15:45:06Z; it correctly rewrote the phrase and pushed commit 62003ef5347bb2f96af9087911d53c14d6f73699 at 15:51:37Z. By then GitHub had already deleted the merged PR's branch agent/103-governed-spec-hierarchy, so the push silently recreated the branch from scratch (log shows [new branch]) rather than updating the (already-merged) PR. No new PR was opened, so the fix was never reviewed or landed. The fix agent then commented on the closed PR claiming the fix was applied. I confirmed directly against the current repo that the defect is still present verbatim ('the documents listed above') as of today.

What could go better

This is a concrete, low-effort, high-confidence fix with no existing tracking issue (verified via search). The correct fix content already exists in git history on the orphaned commit, so no re-analysis is needed -- it just needs to be landed on main. This is also a second concrete instance of the race condition tracked at fullsend-ai/agents#1130 (fix agent should check PR merge status before pushing), included here as evidence rather than a re-proposal: this occurrence shows the race can strand a correct fix indefinitely behind a misleading 'fixed' claim on a closed PR thread, not just waste compute.

Proposed change

File/track a small doc-fix task in redhat-et/ProtoBot: update AGENTS.md (and its CLAUDE.md mirror) at the 'Aligning skills with the specification hierarchy' section to replace 'the documents listed above' with wording consistent with the path-prefix membership rule (e.g., 'every governed Markdown document under docs/, as defined above'). A maintainer or fix agent can cherry-pick the content from orphaned commit 62003ef5347bb2f96af9087911d53c14d6f73699 on the resurrected branch agent/103-governed-spec-hierarchy directly rather than redoing the analysis.

Validation criteria

After the fix lands on main, grep -n "documents listed above" AGENTS.md should return no matches, and the 'Aligning skills' section should reference the same path-prefix membership definition used in the 'Specification document hierarchy' section. A subsequent review-agent pass on the fixing PR should not repeat the internal-inconsistency finding.


Generated by retro agent from https://github.com/redhat-et/ProtoBot/pull/143

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting orphaned commit 62003ef5347bb2f96af9087911d53c14d6f73699 and the 'Aligning skills with the specification hierarchy' sections in AGENTS.md and CLAUDE.md. Verify the wording matches the path-prefix definition, then run grep -n "documents listed above" AGENTS.md and confirm it returns no matches after the fix lands.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.