redhat-et / redhat-et/ProtoBot

REVIEW_SPEC_HIERARCHY in .fullsend/harness/review.yaml is stale on arrival — missing 4 of AGENTS.md's 12 spec-hierarchy entries, including the directory PR #124 itself added

Open Beginner friendly
#140 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug infra ready-for-triage triaged
Dominant language
Go
Stars
5
Forks
6
Avg merge
23h 24m
Merged PRs (30d)
66

Description

What happened

PR #124 created .fullsend/harness/review.yaml (git log confirms this file has exactly one commit touching it: the PR #124 merge — it did not exist before). Among other settings, it introduced REVIEW_SPEC_HIERARCHY, an env var described in its own comment as 'Spec-document paths from AGENTS.md. Structured input for cross-document consistency checks during review,' feeding the review agent's docs-currency subagent (per .fullsend/config.yaml's agents: review: subagents: docs-currency). Its value lists 8 paths: docs/vision.md, docs/architecture.md, docs/architecture/overview.md, docs/architecture/components.md, docs/architecture/user-interaction-flow.md, docs/architecture/related-work.md, docs/architecture/open-questions.md, docs/decisions/. AGENTS.md's actual 'Specification document hierarchy' section — which this exact same PR also edited, to add docs/architecture/agent-harness/ — lists 12 entries. Four are missing from REVIEW_SPEC_HIERARCHY: docs/architecture/git-integration.md, docs/architecture/validation-rules.md, docs/architecture/drafting-table-ux.md, and docs/architecture/agent-harness/ itself. The PR's own 4 review rounds still caught many real cross-document findings via the primary review model's general reasoning (independent of this env var), so I found no concrete finding this specific gap caused to be missed on PR #124 — but it means the docs-currency subagent's structured input has been incomplete since the moment it was created, in the same PR that just extended the hierarchy it's supposed to mirror.

What could go better

High confidence the list is objectively incomplete — I diffed REVIEW_SPEC_HIERARCHY directly against the current AGENTS.md hierarchy section. Medium confidence on impact: this is a latent risk for the docs-currency subagent's structured cross-checks on future PRs touching git-integration.md, validation-rules.md, drafting-table-ux.md, or agent-harness/, rather than a proven miss on this PR, since the broader review model appears to reason about these files anyway. I checked issue #107 ('Upgrade docs-currency subagent model to improve spec-document cross-checks') and confirmed it addresses a different concern (model capability), not the hierarchy list's completeness, so this is not a duplicate.

Proposed change

Update REVIEW_SPEC_HIERARCHY in .fullsend/harness/review.yaml to match AGENTS.md's full 'Specification document hierarchy' list: add docs/architecture/git-integration.md, docs/architecture/validation-rules.md, docs/architecture/drafting-table-ux.md, and docs/architecture/agent-harness/. Optionally, add a comment above REVIEW_SPEC_HIERARCHY (or a cheap CI/skillsaw check) noting that it must be kept in sync with AGENTS.md's hierarchy section whenever that section changes, so the next hierarchy addition (e.g. whatever closes #103) doesn't silently drop out of the review agent's structured input again.

Validation criteria

REVIEW_SPEC_HIERARCHY's path set matches AGENTS.md's 'Specification document hierarchy' list 1:1. On the next PR that adds an entry to AGENTS.md's hierarchy, the same PR (or a review finding on it) also updates REVIEW_SPEC_HIERARCHY, rather than the drift being caught only by a later retro.


Generated by retro agent from https://github.com/redhat-et/ProtoBot/pull/124

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the Specification document hierarchy in AGENTS.md with REVIEW_SPEC_HIERARCHY in .fullsend/harness/review.yaml; read .fullsend/config.yaml for the docs-currency subagent context. Update the list so both path sets match 1:1, then verify that all 12 entries are represented and record synchronization guidance if included.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.