redhat-developer / redhat-developer/yaml-language-server
Tests should check values directly
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 352
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 11
Description
Part of https://github.com/redhat-developer/yaml-language-server/issues/248
Instead of testing whether the response we get back from a feature is not empty we should instead check the values that we get back are correct
https://github.com/redhat-developer/yaml-language-server/blob/master/test/autoCompletion.test.ts#L48
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/autoCompletion.test.ts around line 48, as identified in the issue. Replace the non-empty response check with assertions against the expected returned values, then run the relevant auto-completion tests to confirm the values are checked directly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100