redhat-developer / redhat-developer/vscode-yaml

Number and integer linters do not ignore underscore separator (_)

Open
#977 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
829
Forks
260
Avg merge
5h 43m
Merged PRs (30d)
1

Description

Describe the bug

Per the int and float specs, int and float values should ignore _ to make them readable. Unfortunately the schema validator infers an incorrect type:

image

Expected Behavior

Ignore _.

Current Behavior

Infers incorrect type.

Steps to Reproduce

Create a field with an int or float types (float shown above).

Environment

  • Windows
  • Mac
  • Linux
  • other (please specify)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation files or tests are named. Start by reproducing the issue with integer and float values containing underscore separators, then trace the schema validator's inferred type; done means those values are accepted and inferred as the correct type.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.