redhat-developer / redhat-developer/vscode-yaml
Value highlighting does not correspond to YAML 1.2 specification
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 829
- Forks
- 260
- Avg merge
- 5h 43m
- Merged PRs (30d)
- 1
Description
Describe the bug
With a YAML spec of 1.2 chosen in settings (Default) - the highlighting of values does not correspond to the 1.2 specification as some strings are being highlighted as if boolean. It appears that strings that corresponding to boolean from older specification are being highlighted
Expected Behavior
${{\color{lightskyblue}\Huge{\textsf{Stage:\ }}}}$
${{\color{lightskyblue}\Huge{\textsf{ Axis1:\ }}}}$ ${{\color{darkorange}\Huge{\textsf{ X\ }}}}$
${{\color{lightskyblue}\Huge{\textsf{ Axis2:\ }}}}$ ${{\color{darkorange}\Huge{\textsf{ Y\ }}}}$
${{\color{lightskyblue}\Huge{\textsf{ Axis3:\ }}}}$ ${{\color{darkorange}\Huge{\textsf{ Z\ }}}}$
As per https://yaml.org/spec/1.2.2/
Current Behavior
${{\color{lightskyblue}\Huge{\textsf{Stage:\ }}}}$
${{\color{lightskyblue}\Huge{\textsf{ Axis1:\ }}}}$ ${{\color{darkorange}\Huge{\textsf{ X\ }}}}$
${{\color{lightskyblue}\Huge{\textsf{ Axis2:\ }}}}$ ${{\color{lightskyblue}\Huge{\textsf{ Y\ }}}}$
${{\color{lightskyblue}\Huge{\textsf{ Axis3:\ }}}}$ ${{\color{darkorange}\Huge{\textsf{ Z\ }}}}$
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named in the issue. Start by reproducing the Axis1/Axis2/Axis3 example with the default YAML 1.2 setting and compare the highlighting with the YAML 1.2.2 specification. Done means values that are strings under YAML 1.2 no longer receive boolean highlighting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, yaml
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100