redhat-developer / redhat-developer/vscode-xml

Warnings in extension development

Open
#98 5 comments 1 reaction 1 assignee View on GitHub

@datho7561 is already working on this.

Since Sep 22, 2020.

Dominant language
TypeScript
Stars
328
Forks
101
Avg merge
1d 17h
Merged PRs (30d)
7

Description

Not a blocking issue. Just some annoying warning messages in debug console if I have xml extension installed.

[redhat.vscode-xml] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[xml]', provide the URI of a resource or 'null' for any resource.
[redhat.vscode-xml] Accessing a window scoped configuration for a resource is not expected. To associate 'xml.completion.autoCloseTags' to a resource, define its scope to 'resource' in configuration contributions in 'package.json'.
The first one:

https://github.com/redhat-developer/vscode-xml/blob/32b586ce109b9ac6d1fa2a532d1abb4200a8a26d/src/extension.ts#L128
let configXML = workspace.getConfiguration(undefined, null), ConfigXML.get("[xml]") should work.

The second one:

https://github.com/redhat-developer/vscode-xml/blob/32b586ce109b9ac6d1fa2a532d1abb4200a8a26d/src/extension.ts#L86
https://github.com/redhat-developer/vscode-xml/blob/407cd654cc7d237601d7a926b9eb1773816cdb1a/src/tagClosing.ts#L32
https://github.com/redhat-developer/vscode-xml/blob/32b586ce109b9ac6d1fa2a532d1abb4200a8a26d/package.json#L152-L156

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.