redhat-developer / redhat-developer/vscode-xml

xml.fileAssociations glob pattern miss

Open
#932 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
328
Forks
101
Avg merge
1d 17h
Merged PRs (30d)
7

Description

I am using v0.26.1 and so far everything has been fantastic.

VSCode version info:
Version: 1.82.2 (user setup)
Commit: abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
Date: 2023-09-14T05:55:25.390Z
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621

I want to associate all xml files in a layout/ subfolder:

    "xml.fileAssociations": [
      {
        "pattern": "**/layout/**/*.xml",
        "systemId": "${fileDirname}/RC_schema.xsd"
      }
      ]

This will match for files in subfolders of layout/, such as CFX/layout/menus/my_menu.xml, but not for files directly in layout/, such as CFX/layout/my_page.xml.

According to the glob test tool (https://www.digitalocean.com/community/tools/glob?comments=true&glob=%2A%2A%2Flayout%2F%2A%2A%2F%2A.xml&matches=false&tests=CFX%2Flayout%2Fmy_layout.xml&tests=CFX%2Flayout%2Fmenus%2Fmy_menu.xml), both should match.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported pattern with CFX/layout/my_page.xml and CFX/layout/menus/my_menu.xml using the XML file-association behavior in the extension. Trace how the glob is evaluated and verify that both direct children and nested files under layout/ match when the issue is fixed.

Written by the indexing model from the issue text.

Assessment

Tech stack
vscode, xml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.