redhat-developer / redhat-developer/vscode-xml

[EditorConfig] Respect what's from it before applying local user rules

Open
#904 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
328
Forks
101
Avg merge
1d 17h
Merged PRs (30d)
7

Description

here one among other examples:

[*]
insert_final_newline = true

I don't think "preserver blank line" or "preserve line return" are a match here.
Because one could accept a file trimming, but that last line, especially for git and being a dedicated .editorconfig has a completely different meaning.

Is there a setting in the extension to prevent the removal of the empty last line?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the extension's EditorConfig handling and how local user rules are applied. Reproduce the reported case with insert_final_newline = true, then verify that the EditorConfig rule is respected without removing the final empty line; a suitable regression test should confirm the resulting behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.