redhat-developer / redhat-developer/vscode-xml
`ErrorData` that is generated while finding Java is unused
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 328
- Forks
- 101
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 7
Description
In a few places in requirements.ts, such as https://github.com/redhat-developer/vscode-xml/blob/main/src/server/requirements.ts#L54, we reject the Promise with an object that contains information to set up a dialog instructing the user to download a JDK.
However, we don't use any of this information (note how the error object is unused):
https://github.com/redhat-developer/vscode-xml/blob/main/src/extension.ts#L49
It would be nice to remove all the code in requirements.ts that is not used. It would also be a good idea to investigate where we instruct the user to download Java in the rare cases it's still needed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/server/requirements.ts, especially the Promise rejections around line 54, and compare them with the unused error handling in src/extension.ts around line 49. Trace where Java download guidance is currently produced or expected. Done means removing unused ErrorData-related code and documenting or confirming the remaining Java download path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100