redhat-developer / redhat-developer/vscode-xml

vscode dependency - is it possible to get a "legacy" version?

Open
#742 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build question
Dominant language
TypeScript
Stars
328
Forks
101
Avg merge
1d 17h
Merged PRs (30d)
7

Description

The last one that has no vscode 1.6x dependency was 0.20.0.

Checking the revision history of package.json I see that it was increased to vscode 1.61 in version 0.21.0 to support platform specific extensions (to be able to include the matching graal-vm native built lemminx binary - which seems to be only used if Java is not available on the system) and later to enable a pre-release version (there's no way around it for that) to 1.63.

Rechecked: Those deployment parts seem to be the only reasons for the increased dependency. Are there more?
Manually downloading the vsix from open-vsx (it is not attached as a release artifact, only lemminx binaries are) and replacing the two occurrences of 1.61 with 1.52 in it allows not only installing but (given some tests) also using it with the 1.55 version that is installed on one of the machines I have to use and can't update myself.

Question:

  • Would it be possible (and reasonable) to also provide a "not platform specific" version without the binary (which is still downloaded if no working java is found) - in this one having the dependency set back to 1.52?
  • Would it be possible (and reasonable) to stick with a previous version in the repo (presumably 1.61) and only increase it during CI built of the pre-release version?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with package.json and its revision history around versions 0.20.0 and 0.21.0, then inspect how CI builds the VSIX and pre-release version. Compare a platform-specific package with a package omitting the native binary and using the older VS Code dependency. Done means determining whether both distributions can be produced and supported reasonably.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
build-system, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.