redhat-developer / redhat-developer/vscode-xml
Restart with xml.server.preferBinary when too many crashes occur
Open
Nobody has claimed this yet.
binary
enhancement
- Dominant language
- TypeScript
- Stars
- 328
- Forks
- 101
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 7
Description
At https://github.com/redhat-developer/vscode-xml/blob/master/src/client/clientErrorHandler.ts#L54 , we respond with CloseAction.DoNotRestart, but we now have a binary language server so maybe we should try to set the preference for it and just respond with CloseAction.Restart.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/client/clientErrorHandler.ts at line 54 and inspect how repeated crashes currently return CloseAction.DoNotRestart. Trace how the xml.server.preferBinary preference and binary language server are handled. Done means the crash path enables that preference and returns CloseAction.Restart when appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100