redhat-developer / redhat-developer/vscode-xml

xml.format.maxlinewidth should support changes from the default in vscode namespaces other than 'workspace'

Open
#1,154 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

formatting
Dominant language
TypeScript
Stars
328
Forks
101
Avg merge
1d 17h
Merged PRs (30d)
7

Description

Given the way that the current default for maxlinewidth is set to 100, it means that attempting to overriding the default in any higher namespace will never function. Settings should be able to be modified in any namespace and overriden the closer you get to the project. The typical hierarchy looks something like User->Remote->Workspace. If I change the setting in either (or both) User & remote but leave the workspace unmodified, the default of 100 takes effect.

This is similar to and may have solved #884 & #901 with better configuration options. This is also different than #850

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Locate the xml.format.maxlinewidth setting registration and its configuration-resolution tests, then reproduce the User/Remote/Workspace hierarchy described here. Done means higher-scope values are honored when the workspace leaves the setting unchanged, with closer scopes still taking precedence.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.