redhat-developer / redhat-developer/vscode-xml
Fix security vulnerabilities in v0.29.2025112508
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 328
- Forks
- 101
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 7
Description
Can these vulnerabilities please be addressed?
- 2 Medium severity vulnerabilities (reported here: https://secure.software/vscode/packages/redhat/vscode-xml/vulnerabilities
- Bad HTM filtering regexp in https://github.com/CalgaryGHAS/vscode-redhat-xml/blob/93ac8ca8373d56d272940ee470e0c2f0ac407259/src/client/indentation.ts#L10-L10.
The following regular expression only parses --> and not --!> as a HTML comment end tag: ^\s*(</[-_.A-Za-z0-9]+\b[^>]*>|-->|})
Thank you.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the two medium-severity reports at secure.software and inspect the regular expression in src/client/indentation.ts at line 10. Confirm the reported filtering behavior and identify the required security fixes; done means both reported vulnerabilities are addressed and the documented HTML comment end tag is handled correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- devtools, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100