redhat-developer / redhat-developer/vscode-xml
Formatter broken when use socks5 proxy
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 328
- Forks
- 101
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 7
Description
According to Visual Code's http.proxy settings https://github.com/microsoft/vscode/blob/main/src/vs/platform/request/common/request.ts#L143
It could be "socks5://10.1.2.3:7777", and doesn't match vscode-xml's HOST_AND_PORT_EXTRACTOR
https://github.com/redhat-developer/vscode-xml/blob/main/src/settings/proxySettings.ts#L155
In a word, it will produce a Cannot read properties of null (reading '1') exception, and the language client will not started.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/settings/proxySettings.ts at HOST_AND_PORT_EXTRACTOR and compare its expected proxy format with the SOCKS5 URL described in the issue. Trace the formatter or language-client startup path that reads this setting. Done means a socks5://10.1.2.3:7777 proxy no longer causes the null-property exception and the language client starts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100