redhat-developer / redhat-developer/vscode-openshift-tools
Change in preference of local odo causes extension bundled odo preference change
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 123
- Forks
- 63
- Avg merge
- 6h 16m
- Merged PRs (30d)
- 74
Description
Environment
VS Code version: 1.48.2
OS: darwin
Extension version: 0.1.6
Description
If the local odo has experimental flag set as true , then the extension bundled odo also fetches the same preference and this causes the extension to break.
This happens as the preference is globally set.
Error Trace:
Failed to create Component with error 'Error: Command failed: "/Users/mohitsuman/.vscode/extensions/redhat.vscode-openshift-connector-0.1.6/out/tools/darwin/odo" create nodejs:10 comp124 --git https://github.com/mohitsuman/nodejs-ex --ref HEAD --app app123 --project demo-discon
✗ flag --git, requires --s2i flag to be set, when in experimental mode.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure with the local odo experimental flag enabled and the bundled odo invoked by the extension. Trace how the extension invokes bundled odo and obtains preference values, then verify that local preferences no longer affect it while the reported component-creation scenario succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100