redhat-developer / redhat-developer/vscode-java

Incorrect source level detected using tiles-maven-plugin

Open
#594 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Maven upstream
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

We use the tiles-maven-plugin ( caveat, I'm also a maintainer ) for our projects and include the maven-compiler-plugin settings in a tile, which gets resolved as a parent pom in the effective-pom.

vscode-java however seems to be only looking at the XML file, and not the effective pom when detecting source/target levels - this causes a lot of strange and confusing compile/test issues when building in a terminal, and tabbing back into vscode which seems to rewrite the .class files, causing Maven a lot of confusion ( after quitting vscode - all my odd build issues go away ).

Environment
  • Operating System: Mac OS
  • JDK version: JDK 1.8
  • Visual Studio Code version: 1.25.1
  • Java extension version: 0.28
Steps To Reproduce
  1. clone https://github.com/HalBuilder/halbuilder-core from github
  2. "code ." in the root directory, wait for project parsing etc.
Current Result
  1. Open NamespaceManager.java - lambda calls show as errors
Expected Result
  1. lambda calls show correctly as valid, using the desired source/target levels.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the project-parsing behavior by following the listed steps with halbuiler-core and inspect NamespaceManager.java, where lambda calls are reported incorrectly. Start by comparing the source/target levels from the XML and the effective POM, including the maven-compiler-plugin settings supplied by tiles-maven-plugin. Done means the desired levels are detected and the lambda calls appear valid without causing terminal build conflicts.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, developer-experience
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.