redhat-developer / redhat-developer/vscode-java

JDT.LS binary download does not honour VS Code http.proxy setting in corporate networks

Open
#4,452 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

Problem

On first install (or when the extension downloads a JDT.LS update), the download fails silently in corporate environments that require an authenticated HTTPS proxy. VS Code exposes the proxy via http.proxy and http.proxyAuthorization settings, and also via HTTPS_PROXY / HTTP_PROXY environment variables injected into the extension host. However, the extension's download logic (in src/extension.ts and the download utility) does not read these and passes no proxy configuration to its HTTP client.

Steps to Reproduce

  1. In a corporate environment, set:
    "http.proxy": "http://proxy.corp.example.com:8080",
    "http.proxyStrictSSL": false
    
  2. Install the extension on a machine that has no prior JDT.LS installation.
  3. Open a Java file. The status bar shows "Downloading Java support..." indefinitely.
  4. No error appears; the Output → Java channel shows a TCP timeout to download.jboss.org or the GitHub releases CDN.

Expected Behaviour

The extension should detect the proxy from vscode.workspace.getConfiguration('http').get('proxy') or process.env.HTTPS_PROXY and configure its HTTP download agent accordingly (e.g., via https-proxy-agent or equivalent).

Workaround (not acceptable)

Users currently have to pre-download JDT.LS manually, which is not discoverable and breaks on updates.

Proposed Fix

import HttpsProxyAgent from 'https-proxy-agent';
const proxyUrl = vscode.workspace.getConfiguration('http').get<string>('proxy')
  ?? process.env.HTTPS_PROXY ?? process.env.HTTP_PROXY;
const agent = proxyUrl ? new HttpsProxyAgent(proxyUrl) : undefined;
// Pass agent to node-fetch / got / axios download client

Environment

  • OS: Windows 11 Enterprise 10.0.26200 (mandatory corporate proxy, no direct internet)
  • VS Code: 1.89+
  • Extension: redhat.java latest

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/extension.ts and the download utility, then identify which HTTP client handles JDT.LS downloads and how its agent configuration is passed. Check the VS Code http settings and HTTPS_PROXY/HTTP_PROXY inputs described in the issue. Done means downloads work through an authenticated proxy, including updates, without the reported silent timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.