redhat-developer / redhat-developer/vscode-java

Move Method refactoring causes name shadowing.

Open
#4,300 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug refactoring upstream
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

Select the "methodToBeMoved" in class SourceClass, and move to class TargetClass
Before refactoring

class TargetClass {
}
class SubClass extends TargetClass {
    static public void methodToBeMoved() {
    }
}

class SourceClass {
    TargetClass t;
    void methodToBeMoved() {
    }
}
class TargetClass {
    void methodToBeMoved() {
    }
}
class SubClass extends TargetClass {
    static public void methodToBeMoved() {
    }
}
class SourceClass {
    TargetClass t;
}

Error: This static method cannot hide the instance method from TargetClass

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Move Method refactoring with the Java example in the issue, then trace the refactoring entry point in the vscode-java implementation. The fix is done when moving methodToBeMoved does not create an invalid static method hiding an instance method, while the shown class structure remains valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.