redhat-developer / redhat-developer/vscode-java

Refactoring inline methods leads to changes in access permissions

Open
#3,599 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

potential-duplicate
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

[provide a description of the issue]

Environment

Operating System: Windows11
JDK version: 17
Visual Studio Code version: 1.88
Java extension version: 1.29

Steps To Reproduce
  1. select "originalMethod()"
  2. click “Refacator-inline method”

class OriginalClass {
private boolean flag = false;
public synchronized void originalMethod() throws InterruptedException {
flag = true;
notify();
}

public void callerMethod() throws InterruptedException {
originalMethod() ;
}
}

refactoring result:
image

reason:
Missing "synchronized" keyword decoration, access permissions changed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the case in the issue with the provided Java class, then locate the implementation and tests for the “Refactor-inline method” command. Trace how the original method’s synchronized modifier is handled during inlining; done means the resulting code preserves the original access and synchronization behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.