redhat-developer / redhat-developer/vscode-java

Rebuild All, Rebuild Project and Reload all Maven Projects trigger maven phases up to process-test-classes

Open
#2,890 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

compile Maven regression
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

Since version 1.14.0 the actions Rebuild All, Rebuild Project and Reload all Maven Projects trigger maven phases up to process-test-classes. For us this leads to a huge performance issue (vscode even hangs up) since we use a multi project workspace with multiple maven project that each need to do some expensive stuff (javascript dojo build) in phase process-sources.
Up until now this worked in eclipse and vscode with java extension 1.13.0 like a charm, since both never executed this phase in the UI if not explicitly triggered by a maven build.
Is it by intention or is this a bug? If it is, is there any possibilty to turn this off or any other solution available?

Environment
  • Operating System: Win 10
  • JDK version: jdk-17.0.3.1
  • Visual Studio Code version: 1.74.3
  • Java extension version: 1.14.0
Steps To Reproduce
  1. Import the project
  2. change the file path in the ant plugin in the pom.xml to a path in your system
  3. Click Rebuild All
  4. Now you see, that the file is created and lines are appended whenever one of the actions is executed.

Same steps in version 1.13.0 never writes the file as the phase is not executed.

demo.zip

Current Result

Phase process-sources is executed.

Expected Result

Phase process-sources is not executed like in v1.13.0.

Additional Informations

none

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior with the provided demo.zip, changing the path in the ant plugin in pom.xml, and compare Rebuild All between extension versions 1.13.0 and 1.14.0. Trace which Maven lifecycle phases those actions invoke; done means process-sources is no longer run by these UI actions, matching the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.