redhat-developer / redhat-developer/rhdh-plugins
Skip fullsend review dispatch for changesets-release branches
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 48
- Forks
- 120
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 337
Description
What happened
PR #4428 is an automated changesets version-bump PR on branch changesets-release/ai-integrations/main. The review agent ran (workflow 32422250854), spent ~7 minutes, and approved with a trivial "Looks good to me" — no inline comments, no findings. The diff was 62 additions / 20 deletions across 17 files, all mechanical: package.json version bumps and auto-generated CHANGELOG.md entries. The underlying changes were already reviewed when the originating code PRs merged their changesets. This pattern repeated on 11 of 20 recent merged changeset PRs (55%) across the 3 workspaces in the paths filter. PR #4428 accumulated 8 review dispatches over its lifetime as the long-lived branch was repeatedly synchronized.
What could go better
The review agent's token and compute budget is spent reviewing changes that are (a) purely mechanical version-number edits and changelog boilerplate, and (b) already reviewed as part of the original code PRs that created the changesets. Every review produces a trivial LGTM. The current fullsend.yaml workflow has no condition to distinguish changesets-release branches from code branches. Note: issue #4166 shows the team wants bot-authored PRs reviewed in general — but changesets version-bump PRs are a distinct mechanical subset where full review adds near-zero value compared to, e.g., Renovate dependency bumps that could introduce breaking changes. Confidence: high — the evidence across 20 PRs is consistent (zero non-trivial findings on any changeset PR).
Proposed change
Add a branch-name filter to the pull_request_target trigger in .github/workflows/fullsend.yaml to exclude changesets-release/* branches from dispatching the review (and retro) agents. Specifically, add a branches-ignore clause or an if condition on the dispatch jobs:
pull_request_target:
types: [opened, synchronize, ready_for_review, closed]
branches-ignore:
- 'changesets-release/**'
paths:
- "workspaces/boost/**"
- "workspaces/scorecard/**"
- "workspaces/ai-integrations/**"
Alternatively, if the team prefers to keep the workflow triggered (e.g., for future use) but skip agent dispatch, add an if condition on the review/retro job steps: if: "!startsWith(github.event.pull_request.head.ref, 'changesets-release/')". The branches-ignore approach is simpler and prevents the workflow from running at all on changeset branches.
Validation criteria
After the change, the next 5 merged "Version Packages" PRs in workspaces covered by the paths filter (boost, scorecard, ai-integrations) should have zero fullsend-ai-review[bot] comments and zero review workflow dispatches. Verify by checking gh run list --repo redhat-developer/rhdh-plugins --branch changesets-release/<workspace>/main for absence of new fullsend runs.
Generated by retro agent from https://github.com/redhat-developer/rhdh-plugins/pull/4428
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/fullsend.yaml, inspecting the pull_request_target trigger and the review and retro dispatch jobs. Check how branch filters or job conditions affect the listed event types, then use gh run list for changesets-release//main to verify that the next five covered Version Packages PRs produce no fullsend runs or bot comments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100