redhat-developer / redhat-developer/quarkus-ls

Provide validation for legacy `@ConfigProperties`

Open
#759 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug validation
Dominant language
Java
Stars
50
Forks
18
Avg merge
22h 11m
Merged PRs (30d)
3

Description

Currently, we are validating properties defined using @io.quarkus.arc.config.ConfigProperties in lsp4mp. Specifically, we are doing things like checking if the properties are assigned a value in a config file, and if not, reporting an error in the Java document where the config property is declared. This should not be done in lsp4mp, since @io.quarkus.arc.config.ConfigProperties is a Quarkus-specific feature. Also, this feature is deprecated in Quarkus.

Additionally, we have some tests in lsp4mp that depend on validating these properties in lsp4mp, so we should remove that.

See https://github.com/eclipse/lsp4mp/pull/308/files#diff-c6c8feb661e369033e58718a3149a9816b14608e8fe7be05c857d18383919fd1R111

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the lsp4mp validation for properties declared with @io.quarkus.arc.config.ConfigProperties, using the referenced pull request diff for context. Find the tests that depend on this validation, remove the validation and those tests, and verify that the remaining lsp4mp test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.