redhat-developer / redhat-developer/quarkus-ls
Linked editing should not activate when two template parameters with the same name are declared
Open
Nobody has claimed this yet.
qute
rename
validation
- Dominant language
- Java
- Stars
- 50
- Forks
- 18
- Avg merge
- 22h 11m
- Merged PRs (30d)
- 3
Description
Given the following template:
{@com.github.datho7561.ClassA classA}
{@com.github.datho7561.ClassD classA}
{classA.asdf}
Two issues arise:
- No error is reported for the duplicate object name
- Editing the name of the parameter on either line 1 or line 2 changes the name of the object on line 4. I think this behaviour is bad, since we don't know which type the user intended the reference on line 4.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the duplicate-parameter template in the Quarkus language server and trace how duplicate names are resolved for diagnostics and linked editing. Done means the duplicate declaration reports an error and editing either declaration does not activate linked editing for the ambiguous reference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100