redhat-developer / redhat-developer/mapt
Use Pulumi GitHub provider's getActionsRegistrationToken instead of raw API call
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 24
- Forks
- 36
- Avg merge
- 6d 13h
- Merged PRs (30d)
- 8
Description
Runner registration tokens are currently generated via a raw HTTP call to the GitHub API (pkg/integrations/github/api.go), outside the Pulumi lifecycle. On mapt destroy, the VM is deleted but the runner is never deregistered from GitHub.
Replace with Pulumi's github.getActionsRegistrationToken (https://www.pulumi.com/registry/packages/github/api-docs/getactionsregistrationtoken/) data source. This ties token generation to the Pulumi stack and could enable automatic runner deregistration on destroy. This could also fix the stale runner / name collision problem.
Ref: https://github.com/redhat-developer/mapt/pull/831#discussion_r3499070440
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pkg/integrations/github/api.go, where runner registration tokens are generated through the raw GitHub API call. Read the Pulumi GitHub provider's getActionsRegistrationToken data source documentation and trace how token generation fits into the Pulumi lifecycle. Done means the raw call is replaced and the runner deregistration behavior on mapt destroy is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, go
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100