redhat-cop / redhat-cop/group-sync-operator

Reconcile issue with previously synced group no more available

Open
#319 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
132
Forks
71
PR merge metrics
No merged PRs in 30d

Description

Hi all,
here follows the scenario I have with this issue.

  • (Ldap) Configuration with whitelist in sync regularly and no issue

then:

  • a previously synced group is renamed in ldap
  • the "new" group is added to groupsync whitelist without removing the "old" name
    this caused a reconcile error and sync is stopped for all the whitelisted groups

operator version 0.0.28
here is a log snippet
1.7176737338123524e+09 ERROR syncer_ldap Error building OpenShift group for LDAP group {"LDAP Group UID": "CN=xxxxx,OU=yyyyy,OU=zzzz,DC=kkk,DC=ttt", "error": "search for entry with base dn="OU=yyyyy,OU=zzzz,DC=kkk,DC=ttt" and filter "(&((&(objectClass=group)(memberOf:1.2.840.113556.1.4.1941:=OU=yyyyy,OU=zzzz,DC=kkk,DC=ttt)))(distinguishedName=CN=xxxxxxx,OU=yyyyy,OU=zzzz,DC=kkk,DC=ttt))" did not return any results"}
github.com/redhat-cop/group-sync-operator/pkg/provider/ldap/helpers.(*LDAPGroupSyncer).Sync
/home/runner/work/group-sync-operator/group-sync-operator/pkg/provider/ldap/helpers/groupsyncer.go:87
github.com/redhat-cop/group-sync-operator/pkg/syncer.(*LdapSyncer).Sync
/home/runner/work/group-sync-operator/group-sync-operator/pkg/syncer/ldap.go:241
github.com/redhat-cop/group-sync-operator/controllers.(*GroupSyncReconciler).Reconcile
/home/runner/work/group-sync-operator/group-sync-operator/controllers/groupsync_controller.go:115
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.2/pkg/internal/controller/controller.go:121

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at pkg/provider/ldap/helpers/groupsyncer.go:87 and follow the call path through pkg/syncer/ldap.go:241 to controllers/groupsync_controller.go:115. Reproduce the renamed-group scenario from the log and determine how a missing previously synced LDAP entry affects reconciliation; done means the stale group no longer stops synchronization of the remaining whitelisted groups.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.