zipIgnore should recurse .gitignore files through the project tree

Open
#245 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
50/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
cli

Research direction

Start in packages/cli/src/util/getAppSourceZip.ts at the referenced line and inspect how zipIgnore handles ignored paths. Done means .gitignore files are found through the project tree so files ignored by nested .gitignore files are excluded from the generated source zip.

Written by the indexing model from the issue text.

Description

https://github.com/reddit/devvit/blob/73bac6c43901e4be2671b390507aff4dfe65ce9b/packages/cli/src/util/getAppSourceZip.ts#L21C1-L21C77

See title.
I have a monorepo and some build files from game engine etc. are gitignored only within a subdirectory.
Seems weird that it doesn't recurse.

Dominant language
TypeScript
Stars
210
Forks
88
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reddit/devvit

All issues in reddit/devvit

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.