recloudstream / recloudstream/cloudstream

ABI validation too strict

Open
#3,053 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
10.7k
Forks
1.1k
Avg merge
1d 23h
Merged PRs (30d)
15

Description

It looks like the now merged ABI validation pull request complains when classes are made @Serializable, or when var is changed to val.

I do think we need it, but it triggers on almost any change, including changes which are fine. What are your opinions @Luna712

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the merged ABI validation pull request and reproduce the warnings for making a class @Serializable and changing var to val. Determine which of these changes should be accepted, then verify that valid changes no longer trigger complaints while ABI-breaking changes remain detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.