recloudstream / recloudstream/cloudstream

Missing WRITE_SETTINGS for birghtness

Open Beginner friendly
#2,639 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Kotlin
Stars
10.7k
Forks
1.1k
Avg merge
1d 23h
Merged PRs (30d)
15

Description

Steps to reproduce

Change brightness in the player.

Expected behavior

It should modify system settings.

Actual behavior

It ony modifies the local settings due to a fallback behavior due to lacking perms.

Cloudstream version and commit hash

N/A

Android version

N/A

Logcat
N/A
Other details

The problem is that cs3 does not have a system settings perm "android.permission.WRITE_SETTINGS" in https://github.com/recloudstream/cloudstream/blob/master/app/src/main/AndroidManifest.xml, I think this was removed at some point, but I am unsure when and why.

Acknowledgements
  • I am sure my issue is related to the app and NOT some extension.
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to pre-release version Latest.
  • I will fill out all of the requested information in this form.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with app/src/main/AndroidManifest.xml and inspect the existing brightness-setting entry point to understand how the fallback behaves when the system permission is absent. Check Android's WRITE_SETTINGS requirements and test changing brightness on a device or emulator; done means the player updates system brightness rather than only local settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.