recloudstream / recloudstream/cloudstream
Bad TV navigation for color selection
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 10.7k
- Forks
- 1.1k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 15
Description
Steps to reproduce
Open the dialog for subtitle settings on TV and try to navigate around.
Expected behavior
One should expect that the navigation should work fine, pressing up => focus move up, pressing right => focus move right ect.
Actual behavior
There is currently no nextFocus in the color lib, making navigation hard for TV as it relies on OS navigation. This is an issue due to https://github.com/recloudstream/color-picker-android as it was not designed for TV. A custom override for focus should be done in the lib to fix it in the GridView/Adapter.
Cloudstream version and commit hash
N/A
Android version
N/A
Logcat
Other details
No response
Acknowledgements
- I am sure my issue is related to the app and NOT some extension.
- I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
- I have written a short but informative title.
- I have updated the app to pre-release version Latest.
- I will fill out all of the requested information in this form.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the subtitle settings dialog and the color-picker-android integration, then inspect the GridView/Adapter where focus navigation is handled. Reproduce the dialog on Android TV and verify that directional presses move focus predictably between color choices.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100