reasonml / reasonml/reason

JS object sugar comment interleaving problem

Open
#773 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

KIND: BUG Printer
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

cc @bsansouci @yunxing

Repro:

{
  "myKey":
    /* foo */
    1
}

Prints as:

{
  "myKey":
    1
    /* foo */
};

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the Reason snippet in the report, then trace the formatter or parser behavior that moves the comment after the value. Done when the printed output preserves the comment's position before 1 instead of interleaving it after the value.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, ocaml
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.