reasonml / reasonml/reason

Stack traces in refmt are masked.

Open
#649 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

KIND: FEATURE REQUEST Parser
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

There's a main try block in refmt_impl.ml that does the following:

  with
  | exn ->
    Location.report_exception Format.err_formatter exn;
    exit 1

``

That is apparently masking our stack traces. I don't know what it's supposed to do or how to prevent it from masking stack traces.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the main try block in refmt_impl.ml, especially the exception handler calling Location.report_exception and exit 1. Determine how that handler masks stack traces and identify the intended error-reporting behavior. Done means refmt still reports the exception while preserving useful stack traces.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.