Change # (polymorphic variant abbreviation) to * pattern match.
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 10.3k
- Forks
- 438
- PR merge metrics
- No merged PRs in 30d
Description
Related to #366
Within OCaml it's possible to use polymorphic variant abbreviation patterns (match any of this polymorphic type) which use # as a marker. If we would change the current ` to # it would therefore become ambiguous (https://github.com/facebook/reason/pull/366#issuecomment-225347382).
To work around this ambiguity I think we should change the pattern match #polymorphic-type to *polymorphic-type or something similar.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing related issue #366 and the linked discussion about the syntax ambiguity. Determine the agreed replacement for polymorphic variant abbreviation patterns, then verify the parser and related tests cover the new syntax and reject the ambiguous form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100