reasonml / reasonml/reason

Update `Reason_oprint` functions to use `Format_doc`

Open
#2,871 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

While migrating sketch engine to latest OCaml, i noticed that i had to wrap the usages of Reason_oprint functions like print_out_type with Format_doc.deprecated.

I wonder if Reason should update its implementation to point to the newest handlers exposed after https://github.com/ocaml/ocaml/pull/13169.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Reason_oprint functions mentioned in the issue, including print_out_type, and inspect how they currently relate to Format_doc.deprecated. Compare those handlers with the newest handlers exposed by the linked OCaml change; done means Reason_oprint uses the updated implementation without requiring the migration wrapper described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.