refmt removes unremovable parentheses
Open
Nobody has claimed this yet.
Printer
- Dominant language
- OCaml
- Stars
- 10.3k
- Forks
- 438
- PR merge metrics
- No merged PRs in 30d
Description
We use these helpers in our tests, but refmt breaks them.
https://github.com/ocsigen/tyxml/blob/8551b673857fdc1defebe7c502ffcb920f04009e/test/tyxml_test.ml#L81-L85
Actual behavior:
!:(<p />)!:<p />
Expected behaviour:
!:(<p />)!:(<p />)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/tyxml_test.ml lines 81-85 and reproduce the refmt output for the two helper forms shown. Trace the refmt handling for these parentheses and verify that both forms remain !:(<p />) when the fix is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100