Regression: escaping of "method" breaks JS interop
Open
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 10.3k
- Forks
- 438
- PR merge metrics
- No merged PRs in 30d
Description
The just released BS 7.0.2-dev.1 with the latest refmt compiles
type request;
[@bs.obj] external request: (~method: string) => request = "";
Js.log2("request", request(~method="GET"));
to
console.log("request", {
method_: "GET"
});
I.e. it gives me an object with a field method_. In previous versions, I used to get an object with a field method (as expected).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the Reason snippet with BS 7.0.2-dev.1 and the latest refmt, then compare its generated JavaScript with the previous version. Trace the refmt handling of the external argument named method; done when the generated object uses method rather than method_.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, ocaml
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100