reasonml / reasonml/reason

Doc comment in switch causes parse failure

Open
#2,501 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Parser
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

This is probably related to if not identical to #1687, but we at least need a better error message.

https://reasonml.github.io/try?reason=M4dwlgLgxgFgFARgNQIJQAIDeAod6A+6ATOgLwB86cqu6A9AFS0CGAJq+swHboCmAHhABOzdA3QQA9hJi90wCMyER0kgGYywwdFEkBbPby4QANPOmR0AI167D2hkzwM6tQgH0ylatgC+QA

switch(1+1) {
  | 2 => ()
  /*
  works
  */
  | _ => ()
}
switch(1+1) {
  | 2 => ()
  /**
  doesn't work
  */
  | _ => ()
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Reason Try example and compare the two switch snippets: the ordinary block comment works, while the documentation comment causes a parse failure. Trace the parser behavior for the comment form and finish when this case either parses correctly or reports a clearer error.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.