reasonml / reasonml/reason

Bug: Parsing of tuples and lambdas dependent on parens.

Open
#2,397 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

@let-def Spotted this bug. I have not confirmed it, but filing the report now.

The following parse differently:

f(x => ..., 1)
f((x) => ..., 1)

They should definitely not parse differently. They should both parse as a tuple with the first item being the lambda, second item being 1.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two parsing examples in the issue and inspect the parser entry points handling lambdas, tuples, and parenthesized expressions. Trace why the examples produce different parses; done means both forms parse identically as a tuple containing the lambda followed by 1.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.