reasonml / reasonml/reason

JSX syntax error with infix operators makes poor suggestion

Open
#2,115 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Error messages
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

Given the following syntax:

<div>
(ReasonReact.string("foo" ^ "bar"))
</div>;

Reason gives the following syntax error:

Line 2:29-33 Syntax error, consider adding a `;' before

Using a ; won't help here -- the problem is using OCaml's ^ rather than Reason's ++ to concatenate strings.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the diagnostic with the JSX snippet in the issue and trace the parser's syntax-error suggestion for the infix ^ expression. Done means the error points users toward Reason's ++ string concatenation rather than suggesting an ineffective ;.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, ocaml
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.