refmt pushes pipe inside else branch
Open
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 10.3k
- Forks
- 438
- PR merge metrics
- No merged PRs in 30d
Description
Consider:
if (true) {
false
} else {
true
} |> Js.log;
After refmted, this becomes:
if (true) {
false
} else {
true |> Js.log;
}
which is certainly not what I want.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported example with refmt and compare the input and formatted output around the pipe after the else branch. Locate the formatter entry point responsible for conditional expressions, add regression coverage for this snippet, and verify that the pipe remains outside the else branch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100