reasonml / reasonml/reason

Comments move inside of list literal after longer comment

Open
#2,065 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Parser Printer SKILL: DIFFICULT
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

Using refmt 3.2.0.

Original:

let _ = {
  /* The should be before the list ........................................ */
  [1, 2, 3]
};

After formatting:

let _ = [
  /* The should be before the list ........................................ */
  1,
  2,
  3,
];

The comment is now inside of the [...].

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with refmt 3.2.0 using the Reason snippet in the report, then compare the original and formatted output. Trace the formatter behavior that moves the comment into the list literal. Done means the comment remains before the list while the list is formatted correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.