Multi argument function definition formatting with refmt
Open
Nobody has claimed this yet.
KIND: FEATURE REQUEST
Printer
- Dominant language
- OCaml
- Stars
- 10.3k
- Forks
- 438
- PR merge metrics
- No merged PRs in 30d
Description
Can refmt adopt the Facebook style for multi argument function definitions. It currently formats such functions as:
let withLatestFrom =
(~selector: ('a, 'b) => 'c, other: Observable.t('b))
: Operator.t('a, 'c) =>
In most Facebook codebases (both Hack and JS) you would see this formatted as:
let withLatestFrom =(
~selector: ('a, 'b) => 'c,
other: Observable.t('b),
): Operator.t('a, 'c) =>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with refmt's formatting path for multi-argument function definitions and reproduce the issue's input and current output. Compare it with the requested Facebook-style output; the work is done when refmt consistently emits the requested layout for this form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100