reasonml / reasonml/reason

Unnecessary parens wrapping for switch case followed by lambda

Open
#1,712 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

KIND: FEATURE REQUEST Printer
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

switch foo {
| Bar => a => 1
};

Parses fine, but prints into:

switch foo {
| Bar => (a => 1)
};

cc @jordwalke ok to remove parens here?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the parser and printer behavior with the switch and lambda example shown in the issue. Trace the formatting path for switch-case expressions, then verify that the output omits the unnecessary parentheses while remaining valid Reason syntax.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.