reasonml / reasonml/reason

Functor type signature formats badly

Open
#1,673 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

KIND: FEATURE REQUEST Printer
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

Repro:

module type Screen = (Config: {type transition;}) => {
  type state;
  let run: (state, env) => Config.transition;
}

This formats to:

module type Screen =
  (Config: {type transition;}) => {type state; let run: (state, env) => Config.transition;};

In this particular case I think the former's more desirable. Though I don't know how well that generalizes

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported formatting of the Screen functor snippet in the formatter, then inspect existing formatting behavior for module signatures and functors. Define and verify the desired multiline output for this case and check whether the rule remains consistent for comparable signatures.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.