reasonml / reasonml/reason

[refmt] Unnecessary breaks and indentation in function with many parameters

Open
#1,626 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

KIND: FEATURE REQUEST Printer
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

Input:

let f = (
  someVariable1,
  someVariable2,
  someVariable3,
  someVariable4,
  someVariable5,
  someVariable6
) => 1;

Desired output:

let f = (
  someVariable1,
  someVariable2,
  someVariable3,
  someVariable4,
  someVariable5,
  someVariable6
) => 1;

Actual output:

let f =
    (
      someVariable1,
      someVariable2,
      someVariable3,
      someVariable4,
      someVariable5,
      someVariable6
    ) => 1;

Prettier example for reference: https://goo.gl/Lccqad

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with refmt using the input snippet and compare its output with the desired formatting shown here. The change is complete when a function with many parameters keeps the displayed indentation and line breaks without the extra break before the parameter list.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.