reasonml / reasonml/reason

[refmt] Unnecessary breaks on multi-line functions with explicit type

Open
#1,619 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

KIND: FEATURE REQUEST Printer
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

Input:

let f: int => int = (x) => {
  ();
  x
};

Desired output:

let f: int => int = (x) => {
  ();
  x
};

Actual output:

let f: int => int =
  (x) => {
    ();
    x
  };

Similar prettier example for reference: https://goo.gl/i6QGmo

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running refmt on the provided input and compare its output with the desired formatting. Trace the formatter path for multi-line functions with an explicit type, then add coverage for this example and confirm that refmt preserves the function layout without the unnecessary break.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.